On Fri, Aug 25, 2023 at 07:33:23PM +0200, Thomas Huth wrote:
> On 25/08/2023 19.15, Peter Xu wrote:
> > Add a test for StrOrNull parameters (tls-*).
> >
> > Reviewed-by: Fabiano Rosas <faro...@suse.de>
> > Signed-off-by: Peter Xu <pet...@redhat.com>
> > ---
> > tests/qtest/migration-test.c | 21 +++++++++++++++++++++
> > 1 file changed, 21 insertions(+)
> >
> > diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
> > index 62d3f37021..64efee8b04 100644
> > --- a/tests/qtest/migration-test.c
> > +++ b/tests/qtest/migration-test.c
> > @@ -1471,6 +1471,26 @@ static void test_postcopy_preempt_all(void)
> > #endif
> > +/*
> > + * We have a few parameters that allows null as input, test them to make
> > + * sure they won't crash (where some used to).
> > + */
> > +static void test_null_parameters(void)
> > +{
> > + const char *allow_null_params[] = {
> > + "tls-authz", "tls-hostname", "tls-creds"};
>
> I'd place the ending bracket on a new line.
>
> > + QTestState *vm = qtest_init("");
> > + int i;
> > +
> > + for (i = 0; i < sizeof(allow_null_params) / sizeof(const char *); i++)
> > {
>
> Could you use ARRAY_SIZE() instead of calculating it on your own?
Sure (on both), thanks.
--
Peter Xu
