On Wed, Aug 30, 2023, 7:16 AM Stefan Hajnoczi <stefa...@gmail.com> wrote:
> Hi, > The patch introduces the following build failure: > > cc -m64 -mcx16 -Isubprojects/libvhost-user/libvhost-user.a.p > -Isubprojects/libvhost-user -I../subprojects/libvhost-user > -fdiagnostics-color=auto -Wall -Winvalid-pch -Werror -std=gnu99 -O2 -g > -Wsign-compare -Wdeclaration-after-statement -Wstrict-aliasing > -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -fno-strict-aliasing > -fno-common -fwrapv -fPIE -pthread -D_GNU_SOURCE -MD -MQ > subprojects/libvhost-user/libvhost-user.a.p/libvhost-user.c.o -MF > subprojects/libvhost-user/libvhost-user.a.p/libvhost-user.c.o.d -o > subprojects/libvhost-user/libvhost-user.a.p/libvhost-user.c.o -c > ../subprojects/libvhost-user/libvhost-user.c > In file included from ../subprojects/libvhost-user/include/atomic.h:18, > from ../subprojects/libvhost-user/libvhost-user.c:53: > ../subprojects/libvhost-user/include/compiler.h:38:40: error: missing > binary operator before token "(" > 38 | #if defined(__clang__) && __has_warning("-Waddress-of-packed-member") > | ^ > > https://gitlab.com/qemu-project/qemu/-/jobs/4981576093 Looks like the macros should be removed there too... but I don't know about the subproject tree. Can I submit to it the same way? And for a quick fix... maybe I just move it back to bsd-user/qemu.h until I have more minutes and can test things better or fund the time to setup a Linux build box for docker... Warner > Stefan >