On Wed, Aug 30, 2023 at 01:38:00PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau <marcandre.lur...@redhat.com> > > The timer is only relevant when a text console exists. > > Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> > --- > ui/console.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-)
Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> > diff --git a/ui/console.c b/ui/console.c > index 8c4a2c83fa..ffa68c3a22 100644 > --- a/ui/console.c > +++ b/ui/console.c > @@ -1399,6 +1399,10 @@ qemu_text_console_finalize(Object *obj) > static void > qemu_text_console_class_init(ObjectClass *oc, void *data) > { > + if (!cursor_timer) { > + cursor_timer = timer_new_ms(QEMU_CLOCK_REALTIME, > + text_console_update_cursor, NULL); > + } Any possibility of moving 'cursor_timer' into a field in QemuTextConsole ? With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|