On Sat, Sep 2, 2023 at 5:50 AM Daniel Henrique Barboza <dbarb...@ventanamicro.com> wrote: > > Use a helper in riscv_cpu_add_kvm_properties() to eliminate some of its > code repetition. > > Signed-off-by: Daniel Henrique Barboza <dbarb...@ventanamicro.com> > Reviewed-by: Andrew Jones <ajo...@ventanamicro.com>
Reviewed-by: Alistair Francis <alistair.fran...@wdc.com> Alistair > --- > target/riscv/cpu.c | 24 +++++++++++++----------- > 1 file changed, 13 insertions(+), 11 deletions(-) > > diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c > index d484d63bcd..8cd19a9b9c 100644 > --- a/target/riscv/cpu.c > +++ b/target/riscv/cpu.c > @@ -1978,6 +1978,16 @@ static void riscv_cpu_add_kvm_unavail_prop(Object > *obj, const char *prop_name) > NULL, (void *)prop_name); > } > > +static void riscv_cpu_add_kvm_unavail_prop_array(Object *obj, > + Property *array) > +{ > + g_assert(array); > + > + for (Property *prop = array; prop && prop->name; prop++) { > + riscv_cpu_add_kvm_unavail_prop(obj, prop->name); > + } > +} > + > static void riscv_cpu_add_kvm_properties(Object *obj) > { > Property *prop; > @@ -1986,17 +1996,9 @@ static void riscv_cpu_add_kvm_properties(Object *obj) > kvm_riscv_init_user_properties(obj); > riscv_cpu_add_misa_properties(obj); > > - for (prop = riscv_cpu_extensions; prop && prop->name; prop++) { > - riscv_cpu_add_kvm_unavail_prop(obj, prop->name); > - } > - > - for (prop = riscv_cpu_vendor_exts; prop && prop->name; prop++) { > - riscv_cpu_add_kvm_unavail_prop(obj, prop->name); > - } > - > - for (prop = riscv_cpu_experimental_exts; prop && prop->name; prop++) { > - riscv_cpu_add_kvm_unavail_prop(obj, prop->name); > - } > + riscv_cpu_add_kvm_unavail_prop_array(obj, riscv_cpu_extensions); > + riscv_cpu_add_kvm_unavail_prop_array(obj, riscv_cpu_vendor_exts); > + riscv_cpu_add_kvm_unavail_prop_array(obj, riscv_cpu_experimental_exts); > > for (prop = riscv_cpu_options; prop && prop->name; prop++) { > /* Check if KVM created the property already */ > -- > 2.41.0 > >