On 8/30/23 11:38, marcandre.lur...@redhat.com wrote:
-if get_option('vnc').allowed() and have_system
+if get_option('vnc') \
+  .disable_auto_if(not pixman.found()) \
+  .require(pixman.found()) \
+  .allowed() and have_system

".disable_auto_if()" is not needed, because ".require()" handles it.

However, please add an error message for ".require()" and make it a seprate 
variable:

have_vnc = get_option('vnc') \
  .disable_auto_if(not have_system) \
  .require(pixman.found(),
           error_message: 'cannot enable VNC if pixman is not available') \
  .allowed()

Thanks,

Paolo


Reply via email to