On Fri, 8 Sep 2023 16:17:31 +0200 Igor Mammedov <imamm...@redhat.com> wrote:
> On Fri, 8 Sep 2023 14:45:26 +0200 > Tim Wiederhake <twied...@redhat.com> wrote: > > > Fix a copy-paste-mistake in the FEAT_VMX_EPT_VIPD_CAPS cpuid leaf. > > The mistake became apparent as there were two features with the same name > > in this cpuid leaf. The names are now in line with SDM volume 3, appendix A, > > section 10. > > these names are user facing ABI, and changing > them will break users that set these properties on command line. > > maybe in addition opencode legacy aliases for them (initfn|realize time) > + deprecate old names (so we can drop them eventually) > + warning if old name is used (not sure how to do it easily though) > also you do here 2 different things here, 1 fixing duplicate 2 plain rename I'd split those in 2 different patches and mention in commit message what features you are are actually changing PS: + see next patch comment and apply it here as well > > Fixes: 20a78b02d3 ("target/i386: add VMX features") > > Signed-off-by: Tim Wiederhake <twied...@redhat.com> > > --- > > target/i386/cpu.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/target/i386/cpu.c b/target/i386/cpu.c > > index 7c2c48ac06..f10d343935 100644 > > --- a/target/i386/cpu.c > > +++ b/target/i386/cpu.c > > @@ -1322,8 +1322,8 @@ FeatureWordInfo feature_word_info[FEATURE_WORDS] = { > > NULL, NULL, NULL, NULL, > > "vmx-invvpid", NULL, NULL, NULL, > > NULL, NULL, NULL, NULL, > > - "vmx-invvpid-single-addr", "vmx-invept-single-context", > > - "vmx-invvpid-all-context", > > "vmx-invept-single-context-noglobals", > > + "vmx-invvpid-single-addr", "vmx-invvpid-single-context", > > + "vmx-invvpid-all-context", > > "vmx-invvpid-single-context-noglobals", > > NULL, NULL, NULL, NULL, > > NULL, NULL, NULL, NULL, > > NULL, NULL, NULL, NULL, >