On Fri, 8 Sept 2023 at 12:55, Peter Maydell <peter.mayd...@linaro.org> wrote: > > On Wed, 30 Aug 2023 at 00:24, Richard Henderson > <richard.hender...@linaro.org> wrote: > > > > Changes for v5: > > * Updates for review. > > * Include linux-user ESR changes. > > > > Patch 10 is the only one without review. > > > > > > r~ > > Applied to target-arm.next. Thanks to both you and Aaron > for this work.
It turns out that there's something wrong in the linux-user ESR changes and they trip the clang sanitizer: https://gitlab.com/pm215/qemu/-/jobs/5047578129 TEST linux-test on aarch64 ../linux-user/aarch64/signal.c:583:21: runtime error: member access within null pointer of type 'target_siginfo_t' (aka 'struct target_siginfo') SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../linux-user/aarch64/signal.c:583:21 in make[1]: *** [Makefile:178: run-linux-test] Error 1 where that line number is in need_save_esr() on the first line "int sig = info->si_signo;". On non-sanitizer CI runs you just get a straight SEGV: https://gitlab.com/pm215/qemu/-/jobs/5047578115 TEST linux-test on alpha timeout: the monitored command dumped core Segmentation fault make[1]: *** [Makefile:178: run-linux-test] Error 139 make: *** [/builds/pm215/qemu/tests/Makefile.include:56: run-tcg-tests-aarch64-linux-user] Error 2 make: *** Waiting for unfinished jobs.... I'm going to drop the 3 linux-user patches from target-arm.next. thanks -- PMM
