Re: [PATCH RESEND v5 15/57] target/loongarch: Implement xvreplgr2vr

[Richard Henderson]

On 9/7/23 01:31, Song Gao wrote:

--- a/target/loongarch/insn_trans/trans_vec.c.inc
+++ b/target/loongarch/insn_trans/trans_vec.c.inc
@@ -4407,27 +4407,42 @@ static bool trans_vpickve2gr_du(DisasContext *ctx, 
arg_rv_i *a)
      return true;
  }

-static bool gvec_dup(DisasContext *ctx, arg_vr *a, MemOp mop)

+static bool gvec_dup_vl(DisasContext *ctx, arg_vr *a,
+                        uint32_t oprsz, MemOp mop)
  {
      TCGv src = gpr_src(ctx, a->rj, EXT_NONE);

- if (!avail_LSX(ctx)) {

-        return false;
-    }
+    tcg_gen_gvec_dup_i64(mop, vec_full_offset(a->vd),
+                         oprsz, ctx->vl/8, src);
+    return true;
+}

+static bool gvec_dup(DisasContext *ctx, arg_vr *a, MemOp mop)

+{
      if (!check_vec(ctx, 16)) {
          return true;
      }

check_vec in gvec_dup_vl instead.

Otherwise,
Reviewed-by: Richard Henderson <richard.hender...@linaro.org>


r~