On 9/12/23 18:40, Philippe Mathieu-Daudé wrote: > On 12/9/23 17:55, Laszlo Ersek wrote: >> - The comment is incorrectly indented / formatted. >> >> - The comment states a 8MB limit, even though the code enforces a 16MB >> limit. >> >> Both of these warts come from commit 0657c657eb37 ("hw/i386/pc: add max >> combined fw size as machine configuration option", 2020-12-09); clean >> them >> up. >> >> Arguably, it's also better to be consistent with the binary units >> (such as >> "MiB") that QEMU uses nowadays. >> >> Cc: "Michael S. Tsirkin" <m...@redhat.com> (supporter:PC) >> Cc: Marcel Apfelbaum <marcel.apfelb...@gmail.com> (supporter:PC) >> Cc: Paolo Bonzini <pbonz...@redhat.com> (maintainer:X86 TCG CPUs) >> Cc: Richard Henderson <richard.hender...@linaro.org> (maintainer:X86 >> TCG CPUs) >> Cc: Eduardo Habkost <edua...@habkost.net> (maintainer:X86 TCG CPUs) >> Cc: qemu-triv...@nongnu.org >> Fixes: 0657c657eb37 >> Signed-off-by: Laszlo Ersek <ler...@redhat.com> >> --- >> >> Notes: >> v2: >> - use the binary units MiB, KiB, GiB comprehensively in the >> comment > > I was going to suggest that ;) > > Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>
And when I was writing the patch, I was 100% sure that you were going to be my first reviewer. :) Thanks! Laszlo > >> >> hw/i386/pc.c | 12 ++++++------ >> 1 file changed, 6 insertions(+), 6 deletions(-) >