On Wed, Sep 13, 2023 at 8:30 PM Peter Xu <pet...@redhat.com> wrote: > > On Thu, Sep 07, 2023 at 06:04:06AM -0700, Mattias Nissler wrote: > > @@ -3105,6 +3105,9 @@ void address_space_init(AddressSpace *as, > > MemoryRegion *root, const char *name) > > as->ioeventfds = NULL; > > QTAILQ_INIT(&as->listeners); > > QTAILQ_INSERT_TAIL(&address_spaces, as, address_spaces_link); > > + as->bounce.in_use = false; > > + qemu_mutex_init(&as->map_client_list_lock); > > + QLIST_INIT(&as->map_client_list); > > as->name = g_strdup(name ? name : "anonymous"); > > address_space_update_topology(as); > > address_space_update_ioeventfds(as); > > Missing the counterpart in do_address_space_destroy()?
Of course, thanks for pointing this out. > > Perhaps we should assert on having no one using the buffer, or on the > client list too. I agree it makes sense to put these assertions, but let me dig a bit and do some experiments to see whether these hold true in practice. > > Thanks, > > -- > Peter Xu >