On 9/15/23 21:12, Philippe Mathieu-Daudé wrote:
On 15/9/23 17:25, Harsh Prateek Bora wrote:


On 9/15/23 01:22, Philippe Mathieu-Daudé wrote:
The check on tcg_enabled() make it clearer we want
this call under TCG.


tb_flush already has a check for tcg_enabled() in its definition.
Do we really need to check for same before calling it?

Good point, I didn't notice. I'll replace the call in
tb_flush() by an assertion.

I guess you meant asserting in else case of the check inside ?
We may want to have the check internally only than having every caller to do that.



Thanks
Harsh

Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org>
---
  accel/stubs/tcg-stub.c |  4 ----
  cpu.c                  | 15 +++++++++------
  gdbstub/softmmu.c      |  5 ++++-
  hw/ppc/spapr_hcall.c   |  2 +-
  4 files changed, 14 insertions(+), 12 deletions(-)



Reply via email to