On 9/21/23 12:22, Duan, Zhenzhong wrote:
-----Original Message-----
From: Cédric Le Goater <c...@redhat.com>
Sent: Thursday, September 21, 2023 4:42 PM
Subject: Re: [PATCH v1 05/22] vfio/common: Extract out
vfio_kvm_device_[add/del]_fd
On 9/20/23 13:49, Eric Auger wrote:
Hi Zhenzhong,
On 8/30/23 12:37, Zhenzhong Duan wrote:
...which will be used by both legacy and iommufd backend.
I prefer genuine sentences in the commit msg. Also you explain what you
do but not why.
suggestion: Introduce two new helpers, vfio_kvm_device_[add/del]_fd
which take as input a file descriptor which can be either a group fd or
a cdev fd. This uses the new KVM_DEV_VFIO_FILE VFIO KVM device group,
which aliases to the legacy KVM_DEV_VFIO_GROUP.
Ah yes. I didn't understand why the 's/GROUP/FILE/' change in the
VFIO KVM device ioctls. Thanks for clarifying.
What about pre-6.6 kernels without KVM_DEV_VFIO_FILE support ?
They are purely alias. See below commit:
Ah. I missed that. thanks again.
C.
