On 18/09/2023 22:41, Markus Armbruster wrote: > qemu_rdma_resolve_host() and qemu_rdma_dest_init() try addresses until > they find on that works. If none works, they return the first Error > set by qemu_rdma_broken_ipv6_kernel(), or else return a generic one. > > qemu_rdma_broken_ipv6_kernel() neglects to set an Error when > ibv_open_device() fails. If a later address fails differently, we use > that Error instead, or else the generic one. Harmless enough, but > needs fixing all the same. > > Signed-off-by: Markus Armbruster <arm...@redhat.com>
Wow... IPV6 + RDMA, i have never used it, though Reviewed-by: Li Zhijian <lizhij...@fujitsu.com> > --- > migration/rdma.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/migration/rdma.c b/migration/rdma.c > index be66f53489..08cd186385 100644 > --- a/migration/rdma.c > +++ b/migration/rdma.c > @@ -855,6 +855,8 @@ static int qemu_rdma_broken_ipv6_kernel(struct > ibv_context *verbs, Error **errp) > if (errno == EPERM) { > continue; > } else { > + error_setg_errno(errp, errno, > + "could not open RDMA device context"); > return -EINVAL; > } > }