On Fri, Sep 22, 2023 at 06:37:42PM +0200, Thomas Huth wrote: > When compiling this file with -Wshadow=local , we get: > > ../tests/qtest/m48t59-test.c: In function ‘bcd_check_time’: > ../tests/qtest/m48t59-test.c:195:17: warning: declaration of ‘s’ > shadows a previous local [-Wshadow=local] > 195 | long t, s; > | ^ > ../tests/qtest/m48t59-test.c:158:17: note: shadowed declaration is here > 158 | QTestState *s = m48t59_qtest_start(); > | ^ > > Rename the QTestState variable to "qts" which is the common > naming for such a variable in other tests. > > Reported-by: Markus Armbruster <arm...@redhat.com> > Signed-off-by: Thomas Huth <th...@redhat.com> > --- > tests/qtest/m48t59-test.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-)
Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
