On 02/27/2012 10:33 AM, Federico Simoncelli wrote:
I'm all for the modularity of the commands (I suggested it since
the beginning),
but all this infrastructure goes way beyond what I'd need for oVirt
now.
When I submitted my patches we knew that my work wasn't the
definitive solution
(eg: the future implementation of -blockdev). So I'd suggest to try
and settle
with something that is good enough and that is not preventing a
future improvement.
What about having a (temporary) flag in drive-mirror to accept also
a new-image-file
until we will have the optimal solution?
Unless there are extenuating circumstances (like the absence of core
infrastructure in QEMU), then we should not add commands that we know
are not
the right command.
So are you in favor or against my suggestion?
Against. I think we have everything we need.
It looks like this is exactly
the case where the core infrastructure (transactions) is missing.
Batch requests are incredibly easy to add. I'm stuck in meetings for the next
couple days but I'm sure Luiz throw it together in no time at all.
Regards,
Anthony Liguori
