On 9/26/23 23:39, ebl...@redhat.com wrote: > From: Eric Blake <ebl...@redhat.com> > > Documenting that we should not add new lines to work around SPF > rewrites sounds foreboding; the intent is instead that new lines here > are okay, but indicate a second problem elsewhere in our build process > that we should also consider fixing at the same time, to keep the > section from growing without bounds. > > Mentioning DMARC alongside SPF may also help people grep for this > scenario, as well as documenting the 'git config' workaround that can > be used by submitters to avoid the munging issue in the first place. > > Fixes: 3bd2608d ("maint: Add .mailmap entries for patches claiming list > authorship") > CC: Andrey Drobyshev <andrey.drobys...@virtuozzo.com> > Cc: Peter Maydell <peter.mayd...@linaro.org> > Signed-off-by: Eric Blake <ebl...@redhat.com> > --- > > I'm sending this email with a temporary 'git config sendemail.from > ebl...@redhat.com', to see if the added advice actually adds the extra > line. It did not show up in my editor window, though, so this patch > may need further tweaking to get the instructions right. Since I > don't normally suffer from SPF/DMARC munging, I may not be the best > person to test the right workaround. Or maybe 'git config' does not > yet have the right workaround already available as a turnkey solution > we can suggest. >
The only drawback of this approach is that mail clients, as well as tools like patchew.org now only show your "<email>" in From/Author field. You can see it here: https://patchew.org/search?q=project%3AQEMU+from%3ABlake In your email there're 2 "From:" fields now: > Headers... > From: ebl...@redhat.com > More headers... > From: Eric Blake <ebl...@redhat.com> > Actual patch Apparently, mail clients prefer to pay attention on the very first "From:" entry, while tools like "git am" -- on the last. If we managed to make those entries both be in the format "name <email>" -- that'd be ideal. However, as I pointed out in another thread, if we set sendemail.from to "name <email>", the 2nd entry doesn't get added since they're now identical. So you figure out the way to get 2 identical "From:" entries -- please let us know. Having all that said, it would still be nice to have additional checks for "qemu-bl...@nongnu.org" authorship, as Peter mentioned in the previous thread. Andrey