On Wed, Sep 27, 2023 at 01:41:41PM +0100, Peter Maydell wrote: > On Tue, 26 Sept 2023 at 20:42, Eric Blake <ebl...@redhat.com> wrote: > > > > On Tue, Sep 26, 2023 at 02:46:44PM +0100, Peter Maydell wrote: > > > What did you mean by "we prefer to avoid adding more entries" ? > > > It reads to me like "don't add more entries even if we get more > > > accidental attributed-to-the-list commits" (and I was actually > > > thinking about replying to this patch to say "the mailmap file > > > says we shouldn't add more of these lines"), but presumably since > > > you've reviewed this patch that wasn't the actual intention. > > > Maybe the comment could use clarification. > > > > Indeed, it is meant more along the lines of "because our build process > > was tweaked to warn us in advance of merging more commits that suffer > > from the same problem, we shouldn't be having to continually increase > > the size of this section", or even "if you end up adding a line here, > > please also take the time to figure out what part of our build process > > failed to catch it in advance" (in this particular instance, the > > failure was effectively that we were grepping for 'via qemu-devel', > > not 'via qemu-.*'). > > I've adjusted the line in the apply-pullreq script: > https://git.linaro.org/people/pmaydell/misc-scripts.git/commit/?id=f9a317392e83c84e4fdfcff554f64da3dfb7907b > > Richard, Stefan: you probably want to update your copies. > > (I also noticed we have a few commits from 2021 that were > attributed to qemu-...@nongnu.org.)
All from BALATON Zoltan; I'll add a .mailmap entry for that as a v2 post for my other thread on tweaking the .mailmap comment. -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org
