Hi Gavin,
> From: Gavin Shan <gs...@redhat.com>
> Sent: Wednesday, September 27, 2023 7:30 AM
> To: Salil Mehta <salil.me...@huawei.com>; qemu-devel@nongnu.org; qemu-
> a...@nongnu.org
> Cc: m...@kernel.org; jean-phili...@linaro.org; Jonathan Cameron
> <jonathan.came...@huawei.com>; lpieral...@kernel.org;
> peter.mayd...@linaro.org; richard.hender...@linaro.org;
> imamm...@redhat.com; andrew.jo...@linux.dev; da...@redhat.com;
> phi...@linaro.org; eric.au...@redhat.com; w...@kernel.org; a...@kernel.org;
> oliver.up...@linux.dev; pbonz...@redhat.com; m...@redhat.com;
> raf...@kernel.org; borntrae...@linux.ibm.com; alex.ben...@linaro.org;
> li...@armlinux.org.uk; dar...@os.amperecomputing.com;
> il...@os.amperecomputing.com; vis...@os.amperecomputing.com;
> karl.heub...@oracle.com; miguel.l...@oracle.com; salil.me...@opnsrc.net;
> zhukeqian <zhukeqi...@huawei.com>; wangxiongfeng (C)
> <wangxiongfe...@huawei.com>; wangyanan (Y) <wangyana...@huawei.com>;
> jiakern...@gmail.com; maob...@loongson.cn; lixiang...@loongson.cn
> Subject: Re: [PATCH RFC V2 04/37] arm/virt,target/arm: Machine init time
> change common to vCPU {cold|hot}-plug
>
> On 9/26/23 20:04, Salil Mehta wrote:
> > Refactor and introduce the common logic required during the
> initialization of
> > both cold and hot plugged vCPUs. Also initialize the *disabled* state of the
> > vCPUs which shall be used further during init phases of various other
> > components
> > like GIC, PMU, ACPI etc as part of the virt machine initialization.
[...]
> >
> > Co-developed-by: Salil Mehta <salil.me...@huawei.com>
> > Signed-off-by: Salil Mehta <salil.me...@huawei.com>
> > Co-developed-by: Keqian Zhu <zhukeqi...@huawei.com>
> > Signed-off-by: Keqian Zhu <zhukeqi...@huawei.com>
> > Reported-by: Gavin Shan <gavin.s...@redhat.com>
> ^^^^^^^^^^^^^^^^^^^^^
>
> <gs...@redhat.com>
Ah. Gross. Sorry about this. Will fix.
Thanks
Salil.
>
> > [GS: pointed the assertion due to wrong range check]
> > Signed-off-by: Salil Mehta <salil.me...@huawei.com>
> > ---
> > hw/arm/virt.c | 149 ++++++++++++++++++++++++++++++++++++++++-----
> > target/arm/cpu.c | 7 +++
> > target/arm/cpu64.c | 14 +++++
> > 3 files changed, 156 insertions(+), 14 deletions(-)
> >
