> From: Jonathan Cameron <jonathan.came...@huawei.com> > Sent: Tuesday, October 3, 2023 12:54 PM > To: Salil Mehta <salil.me...@huawei.com> > Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; m...@kernel.org; jean- > phili...@linaro.org; lpieral...@kernel.org; peter.mayd...@linaro.org; > richard.hender...@linaro.org; imamm...@redhat.com; andrew.jo...@linux.dev; > da...@redhat.com; phi...@linaro.org; eric.au...@redhat.com; > oliver.up...@linux.dev; pbonz...@redhat.com; m...@redhat.com; > w...@kernel.org; gs...@redhat.com; raf...@kernel.org; > alex.ben...@linaro.org; li...@armlinux.org.uk; > dar...@os.amperecomputing.com; il...@os.amperecomputing.com; > vis...@os.amperecomputing.com; karl.heub...@oracle.com; > miguel.l...@oracle.com; salil.me...@opnsrc.net; zhukeqian > <zhukeqi...@huawei.com>; wangxiongfeng (C) <wangxiongfe...@huawei.com>; > wangyanan (Y) <wangyana...@huawei.com>; jiakern...@gmail.com; > maob...@loongson.cn; lixiang...@loongson.cn; Linuxarm <linux...@huawei.com> > Subject: Re: [PATCH V2 06/10] hw/acpi: Update GED _EVT method AML with cpu > scan > > > > > aml_notify(aml_name(ACPI_POWER_BUTTON_DEVICE), > > > > diff --git a/include/hw/acpi/cpu_hotplug.h > > > b/include/hw/acpi/cpu_hotplug.h > > > > index 48b291e45e..ef631750b4 100644 > > > > --- a/include/hw/acpi/cpu_hotplug.h > > > > +++ b/include/hw/acpi/cpu_hotplug.h > > > > @@ -20,6 +20,8 @@ > > > > #include "hw/acpi/cpu.h" > > > > > > > > #define ACPI_CPU_HOTPLUG_REG_LEN 12 > > > > +#define ACPI_CPU_SCAN_METHOD "CSCN" > > > > > > This seems to already be defined in hw/acpi/cpu.c > > > Can we drop it from there given that file now includes this > > > header anyway. > > > > Perhaps I can assign this to the macro in the hw/acpi/cpu.c? > hw/acpi/cpu.c includes this header now anyway I think. > So just drop that definition and should all be good.
Ok.
