Hi Philippe, Thanks for the review. The rest is in the pipeline.
Regards, Tong Ho ________________________________ From: Philippe Mathieu-Daudé <phi...@linaro.org> Sent: Monday, October 2, 2023 11:23 PM To: Ho, Tong <tong...@amd.com>; qemu-...@nongnu.org <qemu-...@nongnu.org> Cc: qemu-devel@nongnu.org <qemu-devel@nongnu.org>; alist...@alistair23.me <alist...@alistair23.me>; edgar.igles...@gmail.com <edgar.igles...@gmail.com>; peter.mayd...@linaro.org <peter.mayd...@linaro.org> Subject: Re: [PATCH] xlnx-bbram: hw/nvram: Remove deprecated device reset Hi Tong, On 3/10/23 07:23, Tong Ho wrote: > This change implements the ResettableClass interface for the device. > > Signed-off-by: Tong Ho <tong...@amd.com> > --- > hw/nvram/xlnx-bbram.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org> Since you did this one, do you mind updating the other Xilinx devices? $ git grep -F -- '->reset = ' hw/*/*xlnx* hw/display/xlnx_dp.c:1399: dc->reset = xlnx_dp_reset; hw/dma/xlnx-zdma.c:827: dc->reset = zdma_reset; hw/dma/xlnx-zynq-devcfg.c:387: dc->reset = xlnx_zynq_devcfg_reset; hw/dma/xlnx_csu_dma.c:714: dc->reset = xlnx_csu_dma_reset; hw/dma/xlnx_dpdma.c:601: dc->reset = xlnx_dpdma_reset; hw/intc/xlnx-pmu-iomod-intc.c:539: dc->reset = xlnx_pmu_io_intc_reset; hw/intc/xlnx-zynqmp-ipi.c:362: dc->reset = xlnx_zynqmp_ipi_reset; hw/misc/xlnx-versal-cfu.c:498: dc->reset = cfu_apb_reset; hw/nvram/xlnx-bbram.c:526: dc->reset = bbram_ctrl_reset; hw/nvram/xlnx-versal-efuse-ctrl.c:753: dc->reset = efuse_ctrl_reset; hw/nvram/xlnx-zynqmp-efuse.c:841: dc->reset = zynqmp_efuse_reset; hw/rtc/xlnx-zynqmp-rtc.c:258: dc->reset = rtc_reset; hw/ssi/xlnx-versal-ospi.c:1833: dc->reset = xlnx_versal_ospi_reset;