On Wed, Oct 04, 2023 at 08:00:34PM +0200, Juan Quintela wrote: > Daniel P. Berrangé <berra...@redhat.com> wrote: > > On Tue, Sep 19, 2023 at 12:49:46PM -0400, Peter Xu wrote: > >> On Mon, Sep 18, 2023 at 04:41:14PM +0200, Markus Armbruster wrote: > >> > Oh dear, where to start. There's so much wrong, and in pretty obvious > >> > ways. This code should never have passed review. I'm refraining from > >> > saying more; see the commit messages instead. > >> > > >> > Issues remaining after this series include: > >> > > >> > * Terrible error messages > >> > > >> > * Some error message cascades remain > >> > > >> > * There is no written contract for QEMUFileHooks, and the > >> > responsibility for reporting errors is unclear > >> > >> Even being removed.. because no one is really extending that.. > >> > >> https://lore.kernel.org/all/20230509120700.78359-1-quint...@redhat.com/#t > > > > One day (in another 5-10 years) I still hope we'll get to > > the point where QEMUFile itself is obsolete :-) > > If you see the patches on list, I have move rate limit check outside of > QEMUFile, so right now it is only a buffer to write in the main > migration thread.
Can you point me to that patch(es) as I'm not identifying them yet. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
