In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword.
Signed-off-by: Emmanouil Pitsidianakis <manos.pitsidiana...@linaro.org> --- hw/virtio/virtio-balloon.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c index d004cf29d2..0f0d94bd94 100644 --- a/hw/virtio/virtio-balloon.c +++ b/hw/virtio/virtio-balloon.c @@ -636,56 +636,57 @@ static int virtio_balloon_free_page_hint_notify(NotifierWithReturn *n, void *data) { VirtIOBalloon *dev = container_of(n, VirtIOBalloon, free_page_hint_notify); VirtIODevice *vdev = VIRTIO_DEVICE(dev); PrecopyNotifyData *pnd = data; if (!virtio_balloon_free_page_support(dev)) { /* * This is an optimization provided to migration, so just return 0 to * have the normal migration process not affected when this feature is * not supported. */ return 0; } /* * Pages hinted via qemu_guest_free_page_hint() are cleared from the dirty * bitmap and will not get migrated, especially also not when the postcopy * destination starts using them and requests migration from the source; the * faulting thread will stall until postcopy migration finishes and * all threads are woken up. Let's not start free page hinting if postcopy * is possible. */ if (migrate_postcopy_ram()) { return 0; } switch (pnd->reason) { case PRECOPY_NOTIFY_BEFORE_BITMAP_SYNC: virtio_balloon_free_page_stop(dev); break; case PRECOPY_NOTIFY_AFTER_BITMAP_SYNC: if (vdev->vm_running) { virtio_balloon_free_page_start(dev); break; } /* * Set S_DONE before migrating the vmstate, so the guest will reuse * all hinted pages once running on the destination. Fall through. */ + fallthrough; case PRECOPY_NOTIFY_CLEANUP: /* * Especially, if something goes wrong during precopy or if migration * is canceled, we have to properly communicate S_DONE to the VM. */ virtio_balloon_free_page_done(dev); break; case PRECOPY_NOTIFY_SETUP: case PRECOPY_NOTIFY_COMPLETE: break; default: virtio_error(vdev, "%s: %d reason unknown", __func__, pnd->reason); } return 0; } -- 2.39.2