On Mon, 3 Oct 2022 at 10:09, Alex Bennée <alex.ben...@linaro.org> wrote:
>
>
> Thomas Huth <th...@redhat.com> writes:
>
> > On 29/09/2022 04.32, Jason Wang wrote:
> >> On Thu, Sep 29, 2022 at 1:06 AM Philippe Mathieu-Daudé <f4...@amsat.org>
> >> wrote:
> >>> Jason, Marc-André, could we improve the buildsys check or display
> >>> a more helpful information from the code instead?
> >> It looks to me we need to improve the build.
> >
> > I'm not sure there is anything to improve in the build system -
> > configure/meson.build are just doing what they should: Pick the
> > default value for "slirp" if the user did not explicitly specify
> > "--enable-slirp".
>
> Shouldn't it be the other way round and fail to configure unless the
> user explicitly calls --disable-slirp?
Our standard pattern for configure options is:
--enable-foo : check for foo; if it can't be enabled, fail configure
--disable-foo : don't even check for foo, and don't build it in
no option given : check for foo, decide whether to build in support if
it's present
-- PMM
