Hi Mingjie, a quick and easy way to make your code available for
community review would be to create a fork of qgis on github and then
create a branch on this fork.
This way it will be easier for you to keep it in sync with master and
for the devs to have a look and pull your changes.
On Thu, 23 Jun 2011 16:54:23 -0400, Mingjie Su wrote:
Hi Tim,
We already installed GIT and checked out the master code. We also
created a branch on my machine, I am wondering if I need to get
permission from you to push our branch over to community.
Thanks,
Ming
-----Original Message-----
From: Mingjie Su
Sent: Wednesday, June 22, 2011 9:37 AM
To: 'Tim Sutton'
Cc: Alexander Bruy; qgis-developer@lists.osgeo.org; 'Peter Borissow';
qgis-os...@lists.sourceforge.net; Harsh Govind
Subject: RE: [Qgis-developer] Integrating OSSIM with QGIS
Thanks a lot, Tim. I will take a look at Coding document and follow
the rules.
Ming
-----Original Message-----
From: Tim Sutton [mailto:li...@linfiniti.com]
Sent: Tuesday, June 21, 2011 8:04 PM
To: Mingjie Su
Cc: Alexander Bruy; qgis-developer@lists.osgeo.org; Peter Borissow;
qgis-os...@lists.sourceforge.net; Harsh Govind
Subject: Re: [Qgis-developer] Integrating OSSIM with QGIS
On Tue, Jun 21, 2011 at 6:21 PM, Mingjie Su <su.m...@geoeye.com>
wrote:
Hi Tim,
Attached is our source code. Please let us know your suggestions.
I received it thanks. I am busy building now. Could I point you to
the
CODING document in the top level of master
https://github.com/qgis/Quantum-GIS/blob/master/CODING
Section 2.7 explains the 'nice' way to share patches etc. Your
changes
are out of date with master and as they are not in a patch, they
remove various changes that have been made upstream. Basically if you
follow our guidelines of submitting patches (or creating a fork on
github), it makes it much easier to evaluate your changes.
I got some an error when running cmake:
CMake Error at src/app/CMakeLists.txt:407 (ADD_EXECUTABLE):
Cannot find source file "qgsnewvectorlayerdialog.cpp". Tried
extensions .c
.C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp .hxx .in .txx
I had a quick look at your settings class QgisAppSettings and as Alex
suggests, it would be much better to use the QgsOptions and / or
QSettings to manage this (or even QgsProject if you want to store the
setting per-project).
I'm going to be travelling the next few days, but I will try to test
any updated patches you make available.
Best regards
Thanks,
Ming
-----Original Message-----
From: Tim Sutton [mailto:li...@linfiniti.com]
Sent: Tuesday, June 21, 2011 4:36 AM
To: Alexander Bruy
Cc: Mingjie Su; qgis-developer@lists.osgeo.org; Peter Borissow;
qgis-os...@lists.sourceforge.net; Harsh Govind
Subject: Re: [Qgis-developer] Integrating OSSIM with QGIS
Hi
On Tue, Jun 21, 2011 at 7:58 AM, Alexander Bruy
<alexander.b...@gmail.com> wrote:
Hi,
2011/6/20 Mingjie Su <su.m...@geoeye.com>:
1) Since QGIS is hard coded to use the GDAL provider, we added the
QgisAppSettings class to load the global settings (which is a plain
text file with key/value pair) to select provider.
maybe I miss something in discussion but is this new
class (QgisAppSettings) is neccessary and why not use
QSettings for this? There is a qgsoptions.h/cpp files to
read and write QGIS setting
You are probably correct though its hard to discuss it without
seeing
the code yet.
Regards
Tim
--
Alexander Bruy
--
Tim Sutton - QGIS Project Steering Committee Member (Release
Manager)
==============================================
Please do not email me off-list with technical
support questions. Using the lists will gain
more exposure for your issues and the knowledge
surrounding your issue will be shared with all.
Visit http://linfiniti.com to find out about:
* QGIS programming and support services
* Mapserver and PostGIS based hosting plans
* FOSS Consulting Services
Skype: timlinux
Irc: timlinux on #qgis at freenode.net
==============================================
--
Tim Sutton - QGIS Project Steering Committee Member (Release
Manager)
==============================================
Please do not email me off-list with technical
support questions. Using the lists will gain
more exposure for your issues and the knowledge
surrounding your issue will be shared with all.
Visit http://linfiniti.com to find out about:
* QGIS programming and support services
* Mapserver and PostGIS based hosting plans
* FOSS Consulting Services
Skype: timlinux
Irc: timlinux on #qgis at freenode.net
==============================================
_______________________________________________
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer
_______________________________________________
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer
