Hi Alessandro

>in WFS we have the standard OGC "FILTER" plus the QGIS custom "EXP_FILTER"
>in WMS we have QGIS custom "FILTER"
>
>IMHO the best solution would be to have the same parameters also in WMS, so:
>
>rename WMS QGIS custom  "FILTER" to "EXP_FILTER" and
>implement OGC  "FILTER" even if it's not in the standard

Oh, so we have even three filter possibilities:

1. OGC Filter (done via QgsExpression )
2. Filter with QGIS custom syntax (done via QgsExpression)
3. Filter with provider subset with syntax of data provider (e.g. SQL). Done on provider (DB) side for very fast searches, therefore needs careful parsing against SQL injections

WFS server implements 1+2, WMS server implements 3. There are pros and cons for all of them, so it would be nice to have three parameter name to call all of them for WMS servers.

>Do you think that we can re-use the WFS OGC FILTER code for the WMS OGC FILTER implementation?

QgsOgcUtils::expressionFromOgcFilter

Regards,
Marco

On 11.01.2014 09:47, Alessandro Pasotti wrote:
2014/1/9 Alessandro Pasotti <apaso...@gmail.com <mailto:apaso...@gmail.com>>

    2014/1/9 Marco Hugentobler <marco.hugentob...@sourcepole.ch
    <mailto:marco.hugentob...@sourcepole.ch>>

        >I thought this OGC filtering stuff was already implemented
        for WFS server isn't it?

    Ok, summarizing:

    in WFS we have the standard OGC "FILTER" plus the  QGIS custom
    "EXP_FILTER"
    in WMS we have QGIS custom "FILTER"

    IMHO the best solution would be to have the same parameters also
    in WMS, so:

    rename WMS QGIS custom  "FILTER" to "EXP_FILTER" and
    implement OGC  "FILTER" even if it's not in the standard

    Do you think that we can re-use the WFS OGC FILTER code for the
    WMS OGC FILTER implementation?


Any comment on this?

Should I file a [Feature] ticket?

--
Alessandro Pasotti
w3: www.itopen.it <http://www.itopen.it>


--
Dr. Marco Hugentobler
Sourcepole -  Linux & Open Source Solutions
Weberstrasse 5, CH-8004 Zürich, Switzerland
marco.hugentob...@sourcepole.ch http://www.sourcepole.ch
Technical Advisor QGIS Project Steering Committee

_______________________________________________
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer

Reply via email to