On 23 February 2015 at 19:09, Richard Duivenvoorde <rdmaili...@duif.net> wrote: > On 22-02-15 22:33, Nyall Dawson wrote: > >> ... however... making this change meant we got hit with a Qt bug [1] >> which causes font dialogs with a parent window set to effectively >> discard their results. Arghh! The worst part is that Jürgen had >> actually fixed this issue 3 years ago - I should have checked the git >> history on the effected files to see if there was an explicit reason >> the parent wasn't correctly set for these dialogs. > > Checking git is one thing (I'm not blaming you for not doing this for > every change...), but maybe also add a comment about this above the line > of code, as more and more people are hacking or trying to clean up in > QGIS, and this knowledge should be IN the code instead of heads and githubs? >
Already done (by Jürgen): https://github.com/qgis/QGIS/commit/57ba28c344ed03cd555c31b0301311a93f988e83 Nyall _______________________________________________ Qgis-developer mailing list Qgis-developer@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/qgis-developer