Sure, you are right, Sorry, the commit message was wrong but the code is ok.
Matthias On 06/16/2016 09:28 AM, Neumann, Andreas wrote: > Hi Matthias, > > Column header numbers? Aren't we discussing row header numbers? > > Andreas > > On 2016-06-16 09:25, Matthias Kuhn wrote: > >> Hi Andreas >> >> It took me less time than it took me to write this email >> >> https://github.com/qgis/QGIS/commit/9f704d6e92b922555bddb3a5a648edaac2aedf34 >> >> Matthias >> >> On 06/16/2016 09:18 AM, Neumann, Andreas wrote: >>> Hi Matthias, >>> >>> If there are no negative side effects - I'd like to see the same >>> behaviour like in spreadsheets - an always ascending list, starting from >>> 1 - regardless of the order of the rows. >>> >>> Would this be a lot of work to change this? >>> >>> Andreas >>> >>> On 2016-06-16 09:06, Matthias Kuhn wrote: >>> >>>> Hi Andreas, >>>> >>>> I always thought that they are the feature ID. But not even that, often >>>> they are "feature id - 1", but that's not guaranteed at all. >>>> >>>> We could make it match the feature id. Or the current index in the table >>>> like you propose. >>>> >>>> Matthias >>>> >>>> On 06/16/2016 08:56 AM, Neumann, Andreas wrote: >>>>> Hi, >>>>> >>>>> I'd like to discuss an issue in the attribute table. >>>>> >>>>> There is this very first column (not stored in the provider) which >>>>> lists >>>>> the features as they appear in the provider (by default, if not >>>>> re-ordered by the user). What are these values? Some internal ID not >>>>> present in the data? Or some internal ID from the qt table widget? >>>>> >>>>> I am just wondering, because regarding this first column, QGIS behaves >>>>> different from Spreadsheets. >>>>> >>>>> When you reorder the table in QGIS, this very first column becomes "out >>>>> of order" - spreadsheets always display 1 to xxx - nicely ordered - >>>>> regardless of the sort order. Could QGIS be aligned to the behaviour of >>>>> spreadsheets or is there a particular reason not do so? I think, from a >>>>> users perspective, because these numbers are not present in the data, >>>>> that it would be more useful if they always stay ordered from 1 to xxx >>>>> or 0 to xxx, regardless of sorting. >>>>> >>>>> Thank you for your feedback. >>>>> >>>>> Andreas >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> _______________________________________________ >>>>> Qgis-developer mailing list >>>>> Qgis-developer@lists.osgeo.org >>>>> <mailto:Qgis-developer@lists.osgeo.org> >>>>> <mailto:Qgis-developer@lists.osgeo.org >>>>> <mailto:Qgis-developer@lists.osgeo.org>> >>>>> List info: http://lists.osgeo.org/mailman/listinfo/qgis-developer >>>>> Unsubscribe: http://lists.osgeo.org/mailman/listinfo/qgis-developer >>>>> >>>> _______________________________________________ >>>> Qgis-developer mailing list >>>> Qgis-developer@lists.osgeo.org >>>> <mailto:Qgis-developer@lists.osgeo.org> >>>> <mailto:Qgis-developer@lists.osgeo.org >>>> <mailto:Qgis-developer@lists.osgeo.org>> >>>> List info: http://lists.osgeo.org/mailman/listinfo/qgis-developer >>>> Unsubscribe: http://lists.osgeo.org/mailman/listinfo/qgis-developer >>> >>> >>> >>> > > > > _______________________________________________ Qgis-developer mailing list Qgis-developer@lists.osgeo.org List info: http://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: http://lists.osgeo.org/mailman/listinfo/qgis-developer