of course, I see. I was under the impression that apart from honoring
the option by using the method you would not run into problems if the
api changes.
Bernhard
Am 19.01.2017 um 10:47 schrieb Victor Olaya:
hmm, not a bad idea, but it is actually very easy to do that using
standard QGIS methods (you can see how simple the fix i made is). The
advantage of vector.features is that it honors the option setting,
without the developer having to take care of that.
Cheers
2017-01-19 10:43 GMT+01:00 Bernhard Ströbl <bernhard.stro...@jena.de>:
Hi Victor,
what do you think about enhancing processing's vector.features with an
additional optional flag that returns the selection no matter if the option
is set or not?
Bernhard
Am 19.01.2017 um 10:35 schrieb Victor Olaya:
Good catch
I fixed it and now it uses the selected features, regardless of the
config parameter. The change is in 2.18 and master branches
Thanks!
2017-01-18 10:44 GMT+01:00 Bernhard Ströbl <bernhard.stro...@jena.de>:
Hi all,
processing sports the "Save selected features" algorithm. However if in
processing's options you untick "Use only selected features" the
algorithm
outputs _all_ features of the input layer. Although I know that
processing
works only on selections when the option is ticked IMHO the current
behaviour is not intuitive: if an algorithm in its name (and help) claims
to
do something with the selected features it should do that _all the time_.
Opinions?
Background: I opened a PR [1] yesterday for an algorithm that works on
selected features all the time (won't make sense otherwise) and would
like
processing to be consistent in that respect.
regards
Bernhard
[1] https://github.com/qgis/QGIS/pull/4011
__________ Information from ESET Mail Security, version of virus
signature
database 14787 (20170118) __________
The message was checked by ESET Mail Security.
http://www.eset.com
_______________________________________________
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
__________ Information from ESET Mail Security, version of virus signature
database 14793 (20170119) __________
The message was checked by ESET Mail Security.
http://www.eset.com
__________ Information from ESET Mail Security, version of virus signature
database 14793 (20170119) __________
The message was checked by ESET Mail Security.
http://www.eset.com
__________ Information from ESET Mail Security, version of virus signature
database 14793 (20170119) __________
The message was checked by ESET Mail Security.
http://www.eset.com
__________ Information from ESET Mail Security, version of virus signature
database 14793 (20170119) __________
The message was checked by ESET Mail Security.
http://www.eset.com
_______________________________________________
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
