Hi,
> My fault, I just applied your patch and I didn't try to build!
>
> I'll look into that.
The patch also adds two new files, which you probably forgot to git add.
However, these are exactly the files we do *not* want. I don't know who
wrote them, but they are incompatible with current QJson master.
Instead, what we'd prefer to see is for 0.7.2 to install files which
work like the ones from master. So that an application's cmake logic
which is written for one, also works with the other.
As far as I can see (but I just glimpsed over it), the files from master
are okay. Then, from master CMakeLists.txt, these lines seem to be
relevant at first glance (totally untested):
SET (CMAKECONFIG_INSTALL_DIR
"${LIB_INSTALL_DIR}/cmake/${CMAKE_PROJECT_NAME}" CACHE PATH "Directory
where to install QJSONConfig.cmake")
[snip]
# cmake-modules
CONFIGURE_FILE(${CMAKE_CURRENT_SOURCE_DIR}/QJSONConfig.cmake.in
${CMAKE_CURRENT_BINARY_DIR}/QJSONConfig.cmake
@ONLY)
CONFIGURE_FILE(${CMAKE_CURRENT_SOURCE_DIR}/QJSONConfigVersion.cmake.in
${CMAKE_CURRENT_BINARY_DIR}/QJSONConfigVersion.cmake
@ONLY)
INSTALL(FILES ${CMAKE_CURRENT_BINARY_DIR}/QJSONConfig.cmake
${CMAKE_CURRENT_BINARY_DIR}/QJSONConfigVersion.cmake
DESTINATION "${CMAKECONFIG_INSTALL_DIR}")
I do not know what the purpose of that uninstall file is, but master has
it as well, so maybe it should be added, too.
Kind regards,
Ralf
------------------------------------------------------------------------------
LogMeIn Central: Instant, anywhere, Remote PC access and management.
Stay in control, update software, and manage PCs from one command center
Diagnose problems and improve visibility into emerging IT issues
Automate, monitor and manage. Do more in less time with Central
http://p.sf.net/sfu/logmein12331_d2d
_______________________________________________
QJson-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/qjson-devel
