Hi,

I just took a quick look at the DASH_EXT code and saw something strange:

the variabeles r,at,i are in the original qmail-lspawn initialized at line
405. This is needed because they are used to build the ldap search filter.
Now in the dash patch, they are also used but never initialised. I think
the following should be BEFORE line 404 (where the "#ifdef DASH_EXT" part
begins):

      at = 0;
      r = mail->s;
      i = mail->len;
      for (at = i - 1; r[at] != '@' && at >= 0 ; at--) ;
             /* handels also mailwith 2 @ */


Of course I might be wrong here :)

Greets,

Franky


On Tue, 29 May 2001, Henning Brauer wrote:

> On Tue, May 29, 2001 at 04:38:09PM +0200, Franky Van Liedekerke wrote:
> > great,
> >
> > I was already planning on asking how to get qmail-ldap and ezmlm working
> > together :)
> > Now for the big one: what's the performance impact of this patch?
>
> For each "-" in the adress on more ldap lookup.
> In practice: not noticeable.
>
> --
> * Henning Brauer, [EMAIL PROTECTED], http://www.bsws.de *
> * Roedingsmarkt 14, 20459 Hamburg, Germany               *
> Unix is very simple, but it takes a genius to understand the simplicity.
> (Dennis Ritchie)
>

Reply via email to