On Tue, Jun 19, 2001 at 10:16:01AM +0200, Claudio Jeker wrote:
> The NS-MTA Code was modified in the last release because the (original
> Netscape) code was a security nightmare (there was a potential buffer
> overflow in it). (Side note, it is not possible in qmail to trigger this
> bufferoverflow but it is still bad programming style).
>
> Perhaps we broke something in it. My and Andres problem is we can no
> longer generate those Passwords, so if you can generate some passwords and
> send me the hashes and the cleartext I can check if everithing is OK.
>
Bug found and fixed. A stupid typo and missing line and a line deleted.
Thanks to Allen Belletti for a NS-MTA-MD5 hash.
The fix is attached.
--
later
Claudio
mailto:[EMAIL PROTECTED]
--- /tmp/qldap/digest_md5.c Mon Apr 23 16:42:13 2001
+++ qmail-ldap/digest_md5.c Tue Jun 26 12:15:04 2001
@@ -431,12 +431,12 @@
unsigned char digest[16], c;
if (!stralloc_copys(&saltstr, salt) ) return -1; /* errno set by stralloc */
- c = 86;
+ c = 89;
if (!stralloc_append(&saltstr, &c) ) return -1;
if (!stralloc_cats(&saltstr, passwd) ) return -1;
c = 247;
+ if (!stralloc_append(&saltstr, &c) ) return -1;
if (!stralloc_cats(&saltstr, salt) ) return -1;
- if (!stralloc_0(&saltstr) ) return -1;
/* the stralloc is not freed so we loose some memory (until exit) but
this is better than the possible root exploit that was in the code before
*/
