Re: ipme.c patch

[Scott Gifford]

Adi's patch is actually not correct.  It adds "0.0.0.0" *instead of*
your other interfaces, instead of *in addition to* your other
interfaces.

ipmeprint shows this.  Here's qmail's normal ipme:

    [sgifford@sghome qmail-1.03]$ ./ipmeprint 
    127.0.0.1
    10.0.0.8

here it is with Adi's patch:

    [sgifford@sghome qmail-1.03-adi]$ ./ipmeprint 
    0.0.0.0
    0.0.0.0

and here it is with the patch I just posted:

    [sgifford@sghome qmail-1.03-sg]$ ./ipmeprint 
    0.0.0.0
    127.0.0.1
    10.0.0.8

Thanks for taking a stab at it, though, Adi!  :)

-----ScottG.

adi <[EMAIL PROTECTED]> writes:

> On Mon, Jan 29, 2001 at 06:39:36AM +0000, James wrote:

> > So.. my question is, could someone please post a complete patch to
> > work around this issue? Or at least a URL to their patch?
> 
> Try this patch. Use with your own risk.
> And don't forget to say thank to Scott Gifford @ tir.com.
> 
> Regards,
> 
> P.Y. Adi Prasaja
> 
> --- ipme.c    Mon Jun 15 17:53:16 1998
> +++ /usr/local/src/qmail-1.03/ipme.c  Mon Jan 29 13:48:00 2001
> @@ -74,6 +74,7 @@
>        byte_copy(&ix.ip,4,&sin->sin_addr);
>        if (ioctl(s,SIOCGIFFLAGS,x) == 0)
>          if (ifr->ifr_flags & IFF_UP)
> +          ip_scan("0.0.0.0", &ix.ip);
>            if (!ipalloc_append(&ipme,&ix)) { close(s); return 0; }
>      }
>  #else
> @@ -84,6 +85,7 @@
>         if (ifr->ifr_addr.sa_family == AF_INET) {
>           sin = (struct sockaddr_in *) &ifr->ifr_addr;
>           byte_copy(&ix.ip,4,&sin->sin_addr);
> +            ip_scan("0.0.0.0", &ix.ip);
>           if (!ipalloc_append(&ipme,&ix)) { close(s); return 0; }
>         }
>  #endif