[qmailadmin] Bug in vpopmail 5.3.26 causes problems in QmailAdmin

[Tom Collins]

Apologies for the massive cross-post, but there's a small bug in 
vpopmail 5.3.26 that impacts QmailAdmin.  It will appear the QmailAdmin 
is broken, when it is actually Vpopmail that has a problem.

In the code optimizations from vpopmail 5.3.25 to 5.3.26, a static 
buffer in vgetent() in vpopmail.c was changed to not static.  This was 
a bad idea, and the problem first surfaced when using QmailAdmin.

It's a simple patch, I'm attaching it and pasting it into this email.

--- vpopmail-5.3.26/vpopmail.c  Tue Aug 26 21:08:09 2003
+++ vpopmail-5.3.27/vpopmail.c  Tue Sep  2 16:31:20 2003
@@ -1587,7 +1587,7 @@
 struct vqpasswd *vgetent(FILE *pw)
 {
     static struct vqpasswd pwent;
-    char line[MAX_BUFF];
+    static char line[MAX_BUFF];
     int i=0,j=0;
     char *tmpstr;
     char *tmpstr1;
--- vpopmail-5.3.26/vpopmail.c  Tue Aug 26 21:08:09 2003
+++ vpopmail-5.3.27/vpopmail.c  Tue Sep  2 16:31:20 2003
@@ -1587,7 +1587,7 @@
 struct vqpasswd *vgetent(FILE *pw)
 {
     static struct vqpasswd pwent;
-    char line[MAX_BUFF];
+    static char line[MAX_BUFF];
     int i=0,j=0;
     char *tmpstr;
     char *tmpstr1;


I will probably release 5.3.27 soon.  There isn't much to it other than 
the new Makefile.am, this fix, and some other minor changes to the 
make/install process.

--
Tom Collins
[EMAIL PROTECTED]
http://sniffter.com/ - info on the Sniffter hand-held Network Tester