Hej!

> First of all it looks quite good.

Thanks!

> Just a few comments:
> 
> * Please remove the "splitpane" color value. We could add this later as 
> qooxdoo support more of these values.

Do you want it to be hard coded in the theme.js?

> * Please don't use width/height = 100% in the appearance for the whole 
> splitpane, as the most time this will confuse the user I think. Instead 
> move it to the example.

Instead use QxConst.CORE_AUTO?

> * Your theme.js also contains other stuff from you. Please send only 
> patches which contains the stuff needed for the users to get it to work.

I will. Sorry!

> As this looks very well already, and we have released the 0.5 of 
> qooxdoo, I could imagine to develop this splitpane in the real qooxdoo 
> widgets folder (Which includes a CVS access, but also means that you 
> could not change all of the core without discuss the matter with us). 
> What do you think?

Of course. It must be discussed with you. If we are going to help each
other it must be synchronised, and you are currently the best person of
doing that. I agree totally on this.

Kent

> Sebastian
> 
> 
> 
> 
> > 
> > Please comment on it!
> > 
> > Kent
> > 
> > On Thu, 2006-02-16 at 09:36 +0100, Sebastian Werner wrote:
> >> Kent Olsson schrieb:
> >>> Hej!
> >>>
> >>> Finally, I had some time over to upgrade the last pieces. A few bugs
> >>> still exist related to the layouting design/mechanism, which is the
> >>> weakest point of Qooxdoo at the moment. I will try to come up with
> >>> suggestions on a better design if time permits. Files are attached.
> >>>
> >>> QxSplitPaneLayout class is necessary due to the fact of controlling
> >>> nested split panes and percent/relative or absolute positioning of the
> >>> splitter.
> >>>
> >>> Please give feedback on the widget.
> >> If you send us the needed files it would be fun to test them. :)
> >>
> >> Sebastian
> >>
> >>
> >>> Kent
> >>>
> >>>
> >>>
> >>> -------------------------------------------------------
> >>> This SF.net email is sponsored by: Splunk Inc. Do you grep through log 
> >>> files
> >>> for problems?  Stop!  Download the new AJAX search engine that makes
> >>> searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
> >>> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
> >>> _______________________________________________
> >>> Qooxdoo-devel mailing list
> >>> Qooxdoo-devel@lists.sourceforge.net
> >>> https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
> >>
> >>
> >> -------------------------------------------------------
> >> This SF.net email is sponsored by: Splunk Inc. Do you grep through log 
> >> files
> >> for problems?  Stop!  Download the new AJAX search engine that makes
> >> searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
> >> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
> >> _______________________________________________
> >> Qooxdoo-devel mailing list
> >> Qooxdoo-devel@lists.sourceforge.net
> >> https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
> 
> 
> 
> -------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
> for problems?  Stop!  Download the new AJAX search engine that makes
> searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
> _______________________________________________
> Qooxdoo-devel mailing list
> Qooxdoo-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel



-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
_______________________________________________
Qooxdoo-devel mailing list
Qooxdoo-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel

Reply via email to