Hi!
I've removed this _ownerWindow completely. You don't need to dispose
properties (using addProperty) in qooxdoo. This will be automatically
handled by qooxdoo.
Sebastian
Ulrich Schreiner schrieb:
hi,
first of all: my fix a few days ago was buggy, sorry for this. in the
construtor i initialized the "_shortcutParts" at the end. but it is
possible that the lines
if (QxUtil.isValid(vShortcut)) {
this.setShortcut(vShortcut);
};
initialized this instancevariable, so my line to set this variable to
empty dictionary possibly deleted the shortcuts.
sorry.
another bug (i think) is in the code. in the dispose-method there is the
following code:
proto.dispose = function()
{
if (this.getDisposed()) {
return;
};
this._ownerWindow = null
this._shortcutParts = null;
return QxTarget.prototype.dispose.call(this);
};
the instance-variable "_ownerWindow" was never used in the whole class.
when using QxCommand i always got errors that "_shortcutParts" is empty
in the javascript-console, so i debugged and it seems, that the
"manager" reference which is set by "setManager" is intact, althoug a
QxCommand was disposed.
so i think there is a memory leak, because a diposed QxCommand Object is
never release in memeory; it is referencend by the manager.
i changed the code from
this._ownerWindow = null;
to
this.setManager (null);
hope this is correct.
attached a diff
</usc>
------------------------------------------------------------------------
Index: QxCommand.js
===================================================================
RCS file: /cvsroot/qooxdoo/qooxdoo/source/script/gui/QxCommand.js,v
retrieving revision 1.6
diff -r1.6 QxCommand.js
37a38,39
this._shortcutParts = {};
47d48
< this._shortcutParts = {};
286c287
< this._ownerWindow = null;
---
this.setManager (null);
-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
_______________________________________________
Qooxdoo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
