Re: [qooxdoo-devel] RemoteRequest problem

Dietrich Streifert Thu, 21 Sep 2006 03:05:15 -0700

It seems that Derrell applied the patch to svn with rev. 4291:

Modified: trunk/qooxdoo/frontend/framework/source/class/qx/io/remote/XmlHttpTransport.js
===================================================================
--- trunk/qooxdoo/frontend/framework/source/class/qx/io/remote/XmlHttpTransport.js	2006-09-21 04:37:02 UTC (rev 4290)
+++ trunk/qooxdoo/frontend/framework/source/class/qx/io/remote/XmlHttpTransport.js	2006-09-21 04:50:57 UTC (rev 4291)
@@ -217,7 +217,9 @@
   var vParameters = this.getParameters();
   var vParametersList = [];
   for (var vId in vParameters) {
-    vParametersList.push(vId + qx.constant.Core.EQUAL + vParameters[vId]);
+    vParametersList.push(escape(vId) +
+                         qx.constant.Core.EQUAL +
+                         escape(vParameters[vId]));
   }
 
   if (vParametersList.length > 0) {

Ricardo Borillo schrieb:

Sebastian,

It's ok Fabian's patch or we open a bug?

On 9/18/06, Ricardo Borillo <[EMAIL PROTECTED]> wrote:
Hi,

I agree with you. This patch should solve the problem.

On 9/18/06, Fabian Jakobs <[EMAIL PROTECTED] > wrote:

Hi All,

I would consider this a bug in the transport layer. In my opinion the transport layer should url encode the keys and the parameters.

Best Fabian

Index: C:/Dokumente und Einstellungen/Fabian.Jakobs/workspace_new/qooxdoo_svn/frontend/framework/source/class/qx/io/remote/XmlHttpTransport.js

===================================================================

--- C:/Dokumente und Einstellungen/Fabian.Jakobs/workspace_new/qooxdoo_svn/frontend/framework/source/class/qx/io/remote/XmlHttpTransport.js            (revision 4246)

+++ C:/Dokumente und Einstellungen/Fabian.Jakobs/workspace_new/qooxdoo_svn/frontend/framework/source/class/qx/io/remote/XmlHttpTransport.js            (working copy)

@@ -217,7 +217,7 @@

   var vParameters = this.getParameters();

   var vParametersList = [];

   for (var vId in vParameters) {

-    vParametersList.push(vId + qx.constant.Core.EQUAL + vParameters[vId]);

+    vParametersList.push(escape(vId) + qx.constant.Core.EQUAL + escape(vParameters[vId]));

   }

   if (vParametersList.length > 0) {

Von: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]] Im Auftrag von Ricardo Borillo
Gesendet: Montag, 18. September 2006 09:40
An: qooxdoo Development
Betreff: [qooxdoo-devel] RemoteRequest problem

Hi all,

In this example:

var params = { a:'test', b:'test&', c:'other' };

var req = new qx.io.remote.RemoteRequest("http://xxx/xx", "POST", qx.constant.Mime.XML );
req.setRequestHeader("Content-Type", "application/x-www-form-urlencoded");

for (var i in params)
{
      req.setParameter(i, params[i]);
}

req.addEventListener("completed", function(e) {
   // Some code
}, this);

req.send();

When the request is issued, it generates some URL like this:
http://xxx/xx?nocache=1158563123763&a=test&b=test&&c=other

This request generates an HTTP Error 400: Bad Request.
It's necessary to encode all parameters before the request?

Thanks a lot

--
Salut,
====================================
Ricardo Borillo Domenech
Analista/Programador - Servei d'Informàtica
Universitat Jaume I
http://xml-utils.com

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

_______________________________________________
qooxdoo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel

--

Salut,
====================================
Ricardo Borillo Domenech
Analista/Programador - Servei d'Informàtica
Universitat Jaume I
http://xml-utils.com

--
Salut,
====================================
Ricardo Borillo Domenech
Analista/Programador - Servei d'Informàtica
Universitat Jaume I
http://xml-utils.com
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
qooxdoo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
  

-- 
Mit freundlichen Grüßen
Dietrich Streifert
Visionet GmbH

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

_______________________________________________
qooxdoo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel

Re: [qooxdoo-devel] RemoteRequest problem

Reply via email to