Hugh Gibson schrieb: >> Applied to SVN. Revision: 5487. Hugh, is this solution OK for you now? >> >> Sebastian >> >> >> Sebastian Werner schrieb: >>> OK, I have overseen this issue. The only option I think we have is >>> to remove the method fromHashCode completely. However we could add >>> a method fromDbKey. What do you think? >>> >>> Sebastian > > Still some problems. this._dbKey is a hidden value, so you should provide an > accessor function so that fromDbKey could be called. The documentation for > the return value in fromDbKey mentions "hash".
This is already fixed. > > However, the killer is that not all objects have a db key - and it's not > immediately obvious from the documentation which have and which don't. So > someone may run into strange problems if they try and use fromDbKey. > > As fromHashCode wasn't used at all in the qx code, and it would appear that > no-one else has used it (it's not mentioned in the mailing list in the last > year, and an internet search doesn't find any references), I suggest that you > just delete the function completely. It is then up to the user to create > their own map of hash code to object (which is what I did when I first found > the bug). OK, I agree completely. I have removed the method in SVN revision #5492. > > I suggest that you also clean up the class toHashCode (line 102) and make it > just return the _hashCode member of object, unless the intention was to apply > hashcodes to any object, even those not derived from qx.Object. This however is not possible with the current code base. The event handling and maybe other stuff depends on this functionality. Thank you for your feedback. Sebastian > > Hugh > > ------------------------------------------------------------------------- > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to share your > opinions on IT & business topics through brief surveys - and earn cash > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > _______________________________________________ > qooxdoo-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ qooxdoo-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
