Hi Markus, indeed you are right. You need not to remove the listeners for events. This is just because we have done this the same way previously. (Ok, not a good reason :))
Our current position is that you need to remove all references to other objects to be really sure that there is nothing which leaks. You need to dispose: DOM Nodes, Arrays, Objects, Instances, ... You need not dispose: Strings, Numbers, Booleans Hope this helps. Greetings, Sebastian Markus Bäurle schrieb: > Hi, > > is there a guideline when to override the dispose() method and which objects > need to be disposed there? > When I looked through the qooxdoo framework it seems that anytime an > EventListener is added it is removed again in the dispose() method. > > But in qx.core.Target all EventListeners are destroyed automatically when > qx.core.Target.dispose() is called, so it should not be necessary to remove > them explicitly. > > I currently override dispose() only, when I have one or more members which > have EventListeners or circular references. Is there anything else I should > take into account? > > Regards, > Markus > ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ qooxdoo-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
