Hugh Gibson schrieb:
>> the problem in this case is not the tree, but the widget. All the  
>> methods like getParent, getChildren etc. could not be overwritten  
>> without breaking the whole widget stuff. This is definitely a point  
>> which should made be better with 0.8. But until then I don't see much 
>>  room for improvements, because many of them just will break the  
>> current widget system.
> 
> Point taken regarding overloading the existing methods.
> 
> There is a sub-set of methods already that have "Folder" at the end. How 
> about filling in the gaps:
> 
> getChildrenFolders
> getNextSiblingFolder
> getPreviousSiblingFolder
> hasChildrenFolders (alias for hasContent)
> getDescendantFolders (alias for getItems)
> 
> It seems to me that getFirstVisibleChildOfFolder/ getLastVisibleChildOfFolder 
> are mis-named, as they call getFirstChild/ getLastChild on the container 
> which ignores whether a child is visible or not. They could be renamed to: 
> getFirstChildFolder and getLastChildFolder.

Looks good for me. Can you modify it accordingly and add migration 
support for this?

Sebastian


> 
> These methods should be put into AbstractTreeElement or appropriate overloads 
> created in all tree classes so you can call them from Tree.js, TreeFolder.js 
> or TreeFile.js without any problems.
> 
> Hugh
> 
> -------------------------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job easier.
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> _______________________________________________
> qooxdoo-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
qooxdoo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel

Reply via email to