dperez schrieb:
> With this change, Spinner supports well the enabled property:
> 
> qx.ui.core.Parent.prototype._modifyEnabled = function(val) {
>       qx.ui.core.Widget.prototype._modifyEnabled.apply(this, arguments);
>       var h = this.getChildren();
>       for (var i = 0; i < h.length; i++) {
>               h[i].setEnabled(val);
>       }
> }
> 
> The only problem, is that for some widgets it overwrites the enabled state
> of their children.  It is ok for the Spinner and many compound widgets like
> ComboBox, but could not be for some others.

I don't like this solution, because this could be better solved via 
inheritance or locally in the affected widgets. To overwrite 
_modifyEnabled in parent has to dramatic effect in my opinion.

This will also slow-down the apply because each child validates the 
incoming enabled value, too. Inheritance is definitely the better 
solution here. Let's just wait for 0.7 :)

Sebastian


> 
> What do you think?
> 
> 
> dperez wrote:
>> Hi,
>>
>> Some widgets like qx.ui.form.FieldText correctly implement the enabled
>> property, but others like Spinner and Table don't react to this property.
>>
>> Maybe because they are containers.  Could containers change the enabled
>> state of their children?
>>
>> Regards,
>> David
>>
> 


-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
qooxdoo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel

Reply via email to