dperez schrieb: > Small issues I'm having: > > 1) window.setResizeable() call fails. Look at the sample Window_1.html
sorry, have other things currently. Maybe in some days. > 2) look at comming 7778 in MResizer.js, I've had to undo your changes. My changes are completely OK, but you must place them inside the real class. I really don't see the reason why a resizer mixin should come with width/height etc. This is completely wrong placed there - even if these are identical between Window and Resizer. > > Now the window class doesn't have so many responsabilities. That's good. > > All the code in the events in MResizer.js has been taken from latest > Window.js Fine. Haven't seen this. > > I don't undertand what's bad with attaching the focus to an event. If the method is really meant to be public, than it's OK. For focus() this seems to be the case. Ignore my comment :) Sebastian > > > > Sebastian Werner wrote: >> Sounds like a good idea. This even cleans up the Window class a bit more. >> >> Are you really sure you have not forget any of the changes that have >> been made in Window.js? This is really important. Please double check >> the methods. >> >> Can you please correct all your event listener methods to use protected >> methods? To attach a method "focus" to a event listener isn't a good way >> in my opinion. >> > ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ qooxdoo-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
