Sebastian Werner wrote: > Rüdiger Herrmann schrieb: >> Hi Sebastian, >> >> thanks for the response. Please, see my comments below. >> >> Cheers, >> Rüdiger >> >> Sebastian Werner wrote: >>> Rüdiger Herrmann schrieb: >>>> Is calling dispose on an already dispose object allowed? >>> Yes, but has no further effect. There is a boolean private flag to mark >>> instances as disposed. >>> >>>> Wouldn't it be then more straightforward to remove the destroy() and >>>> only have a dispose() like all the other widgets as well? >>> No, because destroy does a lot more. It deregisters the element from the >>> tree and such stuff. destroy() is meant to be used at runtime, where you >>> operate with the tree e.g. add, remove and move subtrees etc. >> Since I write this destroy() + dispose() sequence only once I don't care >> that much. But still, from a users point of view I would expect that >> those things are handled internally. >> I call remove() to detach an element from a tree and all things >> necessary are done behind the curtains. >> I call dispose() - which I would expect implies remove() - and the >> element is removed and disposed of. > > This is maybe right. Maybe not. I am not sure if dispose() should really > do more than currently. We definitely need a raw dispose which do > nothing more than really "dispose". Maybe we can make it protected and > support an additional public API. > > remove() should remove an element and handle the selection issues > currently covert by destroy(), but it should not dispose() the element, > because it could be used for a drag and drop action or inserted later in > another place. > > All these things are stuff which will be discussed when 0.8 goes to the > planning phase. Maybe you can setup a wiki article to keep your thoughts > until then. Maybe others want contribute their ideas, too. > >>>> Unfortunately, disposing of an element of the treefullcontrol doesn't >>>> work. I just filed a bug: http://bugzilla.qooxdoo.org/show_bug.cgi?id=401 >>> Can you send a mail to Derrell? He maintains the treefullcontrol. >> I Sent an email to Derrell, but shouldn't he be notified about such >> things automatically? >> When filing a bug I don't like having to bother who else I need to notify. > > If you assign the bug to him - yes. Otherwise: no :)
You know - and now I know as well - that the treefullcontrol is Derrell s'. But wouldn't it be more convenient to have a component therefore? This way the reporter doesn't have to know who is responsible for what. > > Sebastian > > >>> Sebastian >>> >>>> Cheers, >>>> Rüdiger >>>> >>>> Sebastian Werner wrote: >>>>> destroy() automatically executes dispose(). So destroy() is enough in >>>>> this case. >>>>> >>>>> Sebastian >>>>> >>>>> >>>>> >>>>> Rüdiger Herrmann schrieb: >>>>>> Thanks for the quick reply. >>>>>> Just the last answer I am not sure I got it. To completely get rid of a >>>>>> tree element I would write >>>>>> treeElement.destroy(); >>>>>> treeElement.dispose(); >>>>>> right? >>>>>> >>>>>> Sebastian Werner wrote: >>>>>>> Rüdiger Herrmann schrieb: >>>>>>>> Hi all, >>>>>>>> >>>>>>>> I have some questions regarding the new way to implement destructors. >>>>>>>> Some information I found here [1]. Is there more information available? >>>>>>>> >>>>>>>> First of all, is it already fully implemented as the document says >>>>>>>> it's >>>>>>>> 'planned'? >>>>>>> Yes, they are. >>>>>>> >>>>>>>> Here the remaining questions >>>>>>>> - do I need to call the superclass destructor and how (if so)? >>>>>>> No. This will be done automatically. >>>>>>> >>>>>>>> - do I need to declare the destruct function in a derived class if >>>>>>>> there >>>>>>>> is nothing to dispose of the class itself? >>>>>>> No. >>>>>>> >>>>>>>> - from the 'outside view' nothing has changed, to dispose of an object >>>>>>>> there is only myObject.dispose() to be called, right? >>>>>>> Yes. >>>>>>> >>>>>>>> - a more specialized question: the AbstractTreeElement of >>>>>>>> treefullcontrol has a destroy function and a destruct function, what >>>>>>>> about these, how do I dispose of a tree element >>>>>>> Dispose=dispose() >>>>>>> >>>>>>> destroy() = remove element and all tree-childs from folder >>>>>>> >>>>>>> Cheers, >>>>>>> >>>>>>> Sebastian >>>>>>> >>>>>>>> Thanks, >>>>>>>> Rüdiger >>>>>>>> >>>>>>>> [1] >>>>>>>> http://qooxdoo.org/documentation/articles/comparison_of_class_declarations_between_0.6.x_and_0.7#destructor >>>>>>>> >>>>>>>> >>>>>>>> ------------------------------------------------------------------------- >>>>>>>> This SF.net email is sponsored by DB2 Express >>>>>>>> Download DB2 Express C - the FREE version of DB2 express and take >>>>>>>> control of your XML. No limits. Just data. Click to get it now. >>>>>>>> http://sourceforge.net/powerbar/db2/ >>>>>>>> _______________________________________________ >>>>>>>> qooxdoo-devel mailing list >>>>>>>> [email protected] >>>>>>>> https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel >>>>>>> ------------------------------------------------------------------------- >>>>>>> This SF.net email is sponsored by DB2 Express >>>>>>> Download DB2 Express C - the FREE version of DB2 express and take >>>>>>> control of your XML. No limits. Just data. Click to get it now. >>>>>>> http://sourceforge.net/powerbar/db2/ >>>>>> ------------------------------------------------------------------------- >>>>>> This SF.net email is sponsored by DB2 Express >>>>>> Download DB2 Express C - the FREE version of DB2 express and take >>>>>> control of your XML. No limits. Just data. Click to get it now. >>>>>> http://sourceforge.net/powerbar/db2/ >>>>>> _______________________________________________ >>>>>> qooxdoo-devel mailing list >>>>>> [email protected] >>>>>> https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel >>>>> ------------------------------------------------------------------------- >>>>> This SF.net email is sponsored by DB2 Express >>>>> Download DB2 Express C - the FREE version of DB2 express and take >>>>> control of your XML. No limits. Just data. Click to get it now. >>>>> http://sourceforge.net/powerbar/db2/ >>>> ------------------------------------------------------------------------- >>>> This SF.net email is sponsored by DB2 Express >>>> Download DB2 Express C - the FREE version of DB2 express and take >>>> control of your XML. No limits. Just data. Click to get it now. >>>> http://sourceforge.net/powerbar/db2/ >>>> _______________________________________________ >>>> qooxdoo-devel mailing list >>>> [email protected] >>>> https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel >>> ------------------------------------------------------------------------- >>> This SF.net email is sponsored by DB2 Express >>> Download DB2 Express C - the FREE version of DB2 express and take >>> control of your XML. No limits. Just data. Click to get it now. >>> http://sourceforge.net/powerbar/db2/ >> >> ------------------------------------------------------------------------- >> This SF.net email is sponsored by DB2 Express >> Download DB2 Express C - the FREE version of DB2 express and take >> control of your XML. No limits. Just data. Click to get it now. >> http://sourceforge.net/powerbar/db2/ >> _______________________________________________ >> qooxdoo-devel mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel > > > ------------------------------------------------------------------------- > This SF.net email is sponsored by DB2 Express > Download DB2 Express C - the FREE version of DB2 express and take > control of your XML. No limits. Just data. Click to get it now. > http://sourceforge.net/powerbar/db2/ ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ qooxdoo-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
