Hi Nick,
I am sorry, our initial idea of disposeProperties() was wrong in my
opinion. The problem is relatively simply to describe. Properties are
controllable from outside and it could not be detected for sure that the
current property value is the one initially configured, if this value is
not stored anywhere else, too. We can not dispose stuff which was not
assigned by the widget itself. For example if a widget configures it's
own border (through the instantiation of a Border instance), then this
border could be redefined by the application developer with, for
example, a shared border instance, used on multiple other widgets, too.
The system must not dispose stuff which was not originally created by
the widget/object itself.
I think the only, even if ugly, work around is to separately store
values assigned to properties e.g. for a constructor like this:
this._button = new qx.ui.form.Button("hello");
this._button.setToolTip(new qx.ui.popup.ToolTip("hello tip"));
we need to modify it to this:
this._button = new qx.ui.form.Button("hello");
this._buttonToolTip = new qx.ui.popup.ToolTip("hello tip");
this._button.setToolTip(this._buttonToolTip);
This would allow us to add an additional:
this._disposeObjects("_buttonToolTip");
to the destructor of this class.
Could you modify your patches accordingly? Thank you for your support.
And sorry for your double work.
Sebastian
Nick Glencross schrieb:
> Clicked too soon!
>
> Here are the patches!
>
> Nick
>
>
> ------------------------------------------------------------------------
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by DB2 Express
> Download DB2 Express C - the FREE version of DB2 express and take
> control of your XML. No limits. Just data. Click to get it now.
> http://sourceforge.net/powerbar/db2/
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> qooxdoo-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
qooxdoo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
