Hi Sebastian,

Sebastian Werner schrieb:
> Hi Dietrich,
>
> thank you for your patch. Some comments:
>
> It may be better to add a new method to Font.js to support a 
> generateStyle() method
>
> In _renderFont you then could use something like this.__fontStyle = 
> value ? value.generateStyle() : "";
>
> Then you can add the generates style to the htmlArr.push in the other 
> methods.
>
>   
Done.

I additionally created renderStyle and resetStyle method which applies 
the font attributes to a map. This avoids the hook with

  this._fontStyleRef = {};
  this._fontStyleRef.style = {};
  this._fontStyle = this._fontStyleRef.style;

  font.renderElement(this._fontSyleRef);

So I can now use:

  this._fontStyle = {};

  font.renderStyle(this._fontStyle);

> And please be sure to also support all the font features e.g. bold, 
> italic, underlined etc.
>
>   
They were not supported before but are now supported.

> Sebastian
>
>
>   

-- 
Mit freundlichen Grüßen
Dietrich Streifert
--
Visionet GmbH
Firmensitz: Am Weichselgarten 7, 91058 Erlangen
Registergericht: Handelsregister Fürth, HRB 6573
Geschäftsführer: Stefan Lindner




-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
qooxdoo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel

Reply via email to