@Fabian: I saw your change in rev. 8628 of trunk where you removed the dependency from qx.theme.classic.Appearance.

Now I'm getting errors about missing appearances in the console. The missing appearances I found:

"table-pane", "table-header", "widget", "image", "atom", "window-captionbar-title", "window-captionbar-icon"

Additionally there is an error message:

060297 ERROR: qx.ui.basic.Label[854]: Failed to update appearance theme: TypeError - vNewAppearanceProperties has no properties at qx.ui.core.Widget:5139
at qx.ui.core.Widget:5268
at qx.ui.core.Parent:1099
at qx.ui.core.Parent:902
at qx.ui.core.Parent:1098
at qx.ui.core.Parent:1099
at qx.ui.core.Parent:902
at qx.ui.core.Parent:1098
at qx.ui.core.Parent:1099
at qx.ui.core.Parent:902
at qx.ui.core.Parent:1098
at qx.ui.core.Parent:1099
at qx.ui.core.Parent:902
at qx.ui.core.Parent:1098
at qx.theme.manager.Appearance:115
at qx.theme.manager.Meta:123
at qx.core.Property:631
at qx.theme.manager.Meta:114
at qx.core.Property:631
at qx.util.ThemeList:72
at qx.core.Target:299
at qx.core.Target:256
at qx.core.Target:186
at qx.ui.core.Widget:6790
at qx.ui.form.Button:212
at qx.core.Target:299
at qx.core.Target:256
at qx.event.handler.EventHandler:976
at qx.event.handler.EventHandler:812
at qx.lang.Function:181

Fabian Jakobs schrieb:
dperez schrieb:
I have tried to comment the extend key, and seen no effect:

qx.Theme.define("qx.theme.ext.Appearance",
{
//  extend : qx.theme.classic.Appearance,

  title : "Ext",

  appearances : ......

}

So, the extend clause adds an unneeded dependency.
Am I right?


dperez wrote:
Hi,

Is it intended to derive the ext.Appearance class from classic.Appearance?
It seems that the ext class redefines all the appearance entries, so there
is no need to inherit.
In this way, if I like more the ext appearance as a starting point, I
could remove from my build the classic one, which takes about 40kb

Regards,
David


Hi David,

the inheritance was mainly used for convenience because we could start with only a small subset and build the whole theme from there. At the point we are now, I think we can remove the dependency and keep both appearances manually in sync. I have done this change in svn now.

Best Fabian

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
qooxdoo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel

--
Mit freundlichen Grüßen
Dietrich Streifert
--
Visionet GmbH
Firmensitz: Am Weichselgarten 7, 91058 Erlangen
Registergericht: Handelsregister Fürth, HRB 6573
Geschäftsführer: Stefan Lindner



-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
qooxdoo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel

Reply via email to