On 6/19/07, [EMAIL PROTECTED]
<[EMAIL PROTECTED]> wrote:
> +     * Please don't reuse the property by modifying the retreived value from
> +     * getRowColors.
> +     *
> +     * Use a fresh created map because otherwise the property system does not
> +     * detect the value change.

This is likely to cause people problems.  They'll forget to create
their own map and spend a lot of time wondering why it doesn't work.
I had the same issue in Tree for the excludeSpecificTreeLines
property.

Instead of returning the map directly, clone the map and return it.
That way, the user can make changes to the returned value and call the
setter.  That's much more user-friendly than requiring the user to
recreate a map.

(See getExcludeSpecificTreeLines() in qx.ui.tree.Tree for what I did
previously.  Note, however, that in that case it's an array rather
than a map.)

Cheers,

Derrell

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
qooxdoo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel

Reply via email to