Di 11 Sep 2007 09:38:23 UTC von Sebastian Werner an qooxdoo Development
Betreff: Re: [qooxdoo-devel] Extending the Table with dynamic cellEditors and cellRenders
Derrell Lipman schrieb:> On 9/8/07, *bibliograph*
> > wrote:
>
> Hello,
>
> attached you find a patch (you need to rename the .zipp extension back
> to .zip) to the qx.ui.table package which adds the following classes :
>
>
> Christian, this will be a nice addition!
>
>
> As you can see from the demobrowser page, it works in principle, but
> there are a few bugs left, some of which I can fix, others need
> intervention by the framework developers. I have already posted the
> biggest problem to the list: If I try to select a list item in the drop
> down menu of the combobox, it aborts with an error (vFocusTarget has no
> properties in qx/event/handler/EventHandler.js, Line 920). There is a
> problem with focus management there.
>
>
> I believe that these bugs should be fixed before it gets applied to the
> 0.7 branch. The 0.7 branch is not a "development" branch per se, so it
> should, I think, always be in a fully "working" state. It is the
> current "release" and should, I think, act as such. That does, however,
> leave a gap... How does one do development on the current release? Or
> does one? Maybe all new features should be added only to 0.8 and only
> bug fixes belong in 0.7? (I expect a lot of resistance to that
> proposal. :-)
>
> Andreas/Sebastian/Fabian et al, how are you handling the 0.7.2 release?
> Does it make sense to have a 0.7 development branch separate from
> legacy_0_7 where additions to the 0.7 version can be played with?
I think this should be fixed in both, legacy_0_7 and trunk. When this is
easily possible and without side effects. And only if we are really sure
that this is a framework bug and not a usage bug. Patches are welcome
however.
The focus/blur handling of the trunk will differ by major extend from
the old behavior. This is the reason why it is the best to apply it to
both branches - just to be sure it don't get lost.
It is most definitively a framework bug since I only use high-level API functions and do not touch focus management at all. At issue here seems to be that the ComboBox is added to the CellFocusIndicator managed by the Table Pane's Scroller Object and that on mouse click, the Event Target is not determined correctly. As you can see if you apply the patch and try out the demobroser example page, if you select the combo box'es dropdown value with the cursor, everything works fine. It is just when you click on one of the options with the mouse that the error occurs.
Apart from this, there should be no side effects. The only change that I do on *existing* code is to add a reference to the table in the cellInfo object (which does not have any side effects), to add a property to the TextField renderer (which should have no side effects), and add lines of code to the TextField renderer's value getter which validate the result and do nothing if the added property is not set. Everything else will be used only at the decision of the user. So, in principle there should be no side effects.
Thanks, Christian
------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________ qooxdoo-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
