Hi David > Fabian Jakobs-2 wrote: > >>> Great, thank you! Just some minor notes: >>> >>> - Could you move the event class into the table namespace? Since it is >>> >> only used by the table it would be more natural to put it there. >> >> For example to the qx.ui.table.pane.CellEvent? >> Yes, sound good to me.
>>> - I think a context menu event could be useful, too. Do you plan to add >>> > one? > >> Yes, as you can see it's commented out. I just have to locate the method >> in Scroller.js to modify. >> Yes, I have seen it. I just wanted to know. I am not sure if the needed event handler already exists for the context menu. Maybe you have to write one yourself. >> >>> - Some API doc is still missing for the events. >>> >> Which ones? >> The properties of the event and the parameters of the "add/remove-EventListener" methods are still undocumented. >>>> If you like it, I'll will port it to the trunk. >>>> With the current infraestructure, it's easy to create new cell events. >>>> >>>> >>> That would be great. Once you are done with it it should definitively be >>> ported to trunk. >>> >> I will, when I have made your proposed changes Perfect. Best Fabian -- Fabian Jakobs JavaScript Framework Developer 1&1 Internet AG Brauerstraße 48 76135 Karlsruhe Amtsgericht Montabaur HRB 6484 Vorstand: Henning Ahlert, Ralph Dommermuth, Matthias Ehrlich, Andreas Gauger, Matthias Greve, Robert Hoffmann, Norbert Lang, Achim Weiss Aufsichtsratsvorsitzender: Michael Scheeren ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ qooxdoo-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
