I'd say open a bug and attach your pull request. It's worth looking into.

T.

On 03/06/2012 09:47 AM, John Spackman wrote:
Does anybody have any thoughts on this? I'd like to submit a bug & a pull request but OTOH something this low level could have subtle implications and I'm concerned I don't know enough about potential issues.

Thanks
John

From: John Spackman <[email protected] <mailto:[email protected]>> Reply-To: qooxdoo Development <[email protected] <mailto:[email protected]>>
Date: Fri, 02 Mar 2012 15:36:53 +0000
To: qooxdoo Development <[email protected] <mailto:[email protected]>>
Subject: [qooxdoo-devel] Unicode characters and qx.lang.String.trim

Hi

I came across an odd bug today -- after getting some text from DOM nodes and then passing it to qx.lang.String.trim(), what I thought was an empty string had a length of 1. It turned out to contain unicode character u+ffef, also known as "Zero Width No-Break Space" - I found an article [1] that goes some way to explaining it and also mentions other unicode space characters u+FEFF, u+200B, u+200D, and u+2060.

At the moment qx.lang.String.trim, trimLeft, trimRight, and clean only remove characters that match the \s regex, but should this be expanded to include other Unicode whitespace characters? Would it be detrimental to Qx users if it was changed?

[1] http://blogs.msdn.com/b/michkap/archive/2005/01/20/357028.aspx

John
------------------------------------------------------------------------------ Virtualization & Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/_______________________________________________ qooxdoo-devel mailing list [email protected] <mailto:[email protected]> https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel


------------------------------------------------------------------------------
Keep Your Developer Skills Current with LearnDevNow!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-d2d


_______________________________________________
qooxdoo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
------------------------------------------------------------------------------
Keep Your Developer Skills Current with LearnDevNow!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-d2d
_______________________________________________
qooxdoo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel

Reply via email to