I think I may have briefly mentioned this before, but as part of my maven work I tried running code style checking tools, and all I can say is "Yikes!" There were many errors because the Qpid Java code doesn't follow industry-standard (Sun) coding style guidelines.

Is there a good reason for this? I don't want to open the can of worms that typically accompanies coding style questions, but I can't think of any good reason why Qpid should diverge from well-accepted industry standards.

Should it be corrected?

My opinion of the answer to the second question is that yes, it should be corrected. The reason is that it follows the principle of least surprise for developers joining the project, makes it easier for people to work on code written by others, and makes it easier for tools and IDEs to deal with the code. Once the code is fixed, we can easily enforce coding style in our build rules if we so choose.

Thoughts?

--steve

Reply via email to